Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage - move AtomicStorage to a new package #530

Merged
merged 13 commits into from
Feb 1, 2021
Merged

Storage - move AtomicStorage to a new package #530

merged 13 commits into from
Feb 1, 2021

Conversation

anandrgitnirman
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 22, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 67.925% when pulling f75cad2 on anandrgitnirman:storage into a96009c on singnet:master.

ksridharbabuus
ksridharbabuus reviewed Jan 24, 2021
View reviewed changes
Copy link

@ksridharbabuus ksridharbabuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine.
Sometime in review itself I am not able to figure it out between storage2 vs storage reference.
Is it possible to provide appropriate name.

vsbogd
vsbogd reviewed Jan 25, 2021
View reviewed changes
etcddb/etcddb_test.go Outdated Show resolved Hide resolved
ksridharbabuus
ksridharbabuus approved these changes Jan 27, 2021
View reviewed changes
Copy link

@ksridharbabuus ksridharbabuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

singnet#504 Code review comment on keeping etcddb testunder etcddb pa…
f75cad2 
…ckage and removing Prepaid related test cases to the escrow package
@anandrgitnirman anandrgitnirman merged commit 63016e1 into singnet:master Feb 1, 2021
@anandrgitnirman anandrgitnirman deleted the storage branch May 9, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsbogd vsbogd vsbogd approved these changes

@ksridharbabuus ksridharbabuus ksridharbabuus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandrgitnirman @coveralls @vsbogd @ksridharbabuus